URL: https://github.com/SSSD/sssd/pull/765 Author: pbrezina Title: #765: sudo: format runas attributes to correct output name Action: opened
PR body: """ sudo internally calls getpwnam and getgrnam on user and groups that should be used for the invoked command. Output of these calls is compared to values in runAsUser/Group attributes.
When different output format is used then what is present in LDAP, this comparison will fail, denying user to use sudo. Now, we convert these attributes into correct output name, respecting domain resolution order, fully qualified domains and fqname format.
E.g. sudo call: sudo -u tuser@ipa.vm -g tgroup@ipa.vm id
Resolves: https://pagure.io/SSSD/sssd/issue/3957 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/765/head:pr765 git checkout pr765
URL: https://github.com/SSSD/sssd/pull/765 Title: #765: sudo: format runas attributes to correct output name
pbrezina commented: """ Customer confirmed this fix the issue. """
See the full comment at https://github.com/SSSD/sssd/pull/765#issuecomment-472361236
URL: https://github.com/SSSD/sssd/pull/765 Title: #765: sudo: format runas attributes to correct output name
jhrozek commented: """ The patch also looks good to me, but I tried to write an integration tests and have some issues. I would like to find some time with you tomorrow to debug the test. Can you ping me on IRC please? """
See the full comment at https://github.com/SSSD/sssd/pull/765#issuecomment-472529742
URL: https://github.com/SSSD/sssd/pull/765 Title: #765: sudo: format runas attributes to correct output name
jhrozek commented: """ At least I was able to write a test for generic runAs functionality. But I'm not sure our test infrastructure makes it easy to write a regression test for this issue. I'll submit the existing test now and continue on the regression test later. """
See the full comment at https://github.com/SSSD/sssd/pull/765#issuecomment-477128013
URL: https://github.com/SSSD/sssd/pull/765 Title: #765: sudo: format runas attributes to correct output name
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/765 Title: #765: sudo: format runas attributes to correct output name
jhrozek commented: """ * master: * 0aa657165f189035c160beda4840e3271fc56c88 * d411febc98da36eb961b9251c1674af802151786 * sssd-1-16: * 3a18e33f983cd17860b6ff41f9d538ee8fcc6d98 * 5ad7f5e817b2bd8ca0f49b1001f4fb987de32c08
"""
See the full comment at https://github.com/SSSD/sssd/pull/765#issuecomment-477340335
URL: https://github.com/SSSD/sssd/pull/765 Author: pbrezina Title: #765: sudo: format runas attributes to correct output name Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/765/head:pr765 git checkout pr765
URL: https://github.com/SSSD/sssd/pull/765 Title: #765: sudo: format runas attributes to correct output name
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
jhrozek -
pbrezina