-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
[PATCH 1/2] Reopen logs when SIGHUP is caught Upon receiving SIGHUP, the monitor signals all services to reopen their debug logs. It is also possible to signal individual services to reopen their particular files.
Fixes: #332
[PATCH 2/2] Package example logrotate script
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/25/2010 01:06 PM, Jakub Hrozek wrote:
[PATCH 1/2] Reopen logs when SIGHUP is caught Upon receiving SIGHUP, the monitor signals all services to reopen their debug logs. It is also possible to signal individual services to reopen their particular files.
Nack.
This is partly my fault. update_monitor_config() is broken and dangerous. I thought I had disabled all access to it. I didn't realize it was still running with SIGHUP.
We disabled it a long while ago with the intent of fixing it eventually, but we ultimately decided that the downtime of a full restart was acceptable. I've been meaning to eliminate that code entirely.
Also, the *_rotate_logs() calls are all identical. They should just be made into a monitor_common_rotate_logs() call similar to monitor_common_res_init().
Fixes: #332
[PATCH 2/2] Package example logrotate script
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/26/2010 05:33 PM, Stephen Gallagher wrote:
Nack.
This is partly my fault. update_monitor_config() is broken and dangerous. I thought I had disabled all access to it. I didn't realize it was still running with SIGHUP.
We disabled it a long while ago with the intent of fixing it eventually, but we ultimately decided that the downtime of a full restart was acceptable. I've been meaning to eliminate that code entirely.
Stephen eliminated that code in a separate patch which has been acked, so the attached patches are rebased on top of his.
Also, the *_rotate_logs() calls are all identical. They should just be made into a monitor_common_rotate_logs() call similar to monitor_common_res_init().
Done. I originally wanted to keep functions local to the separate process (and its function namespace) but I agree that code duplication is bad.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 03/02/2010 10:00 AM, Jakub Hrozek wrote:
On 02/26/2010 05:33 PM, Stephen Gallagher wrote:
Nack.
This is partly my fault. update_monitor_config() is broken and dangerous. I thought I had disabled all access to it. I didn't realize it was still running with SIGHUP.
We disabled it a long while ago with the intent of fixing it eventually, but we ultimately decided that the downtime of a full restart was acceptable. I've been meaning to eliminate that code entirely.
Stephen eliminated that code in a separate patch which has been acked, so the attached patches are rebased on top of his.
Also, the *_rotate_logs() calls are all identical. They should just be made into a monitor_common_rotate_logs() call similar to monitor_common_res_init().
Done. I originally wanted to keep functions local to the separate process (and its function namespace) but I agree that code duplication is bad.
Jakub, I think you may have sent the wrong patch. 0001 does not apply cleanly on top of the current master. Please check your rebase.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 03/04/2010 06:50 PM, Stephen Gallagher wrote:
Jakub, I think you may have sent the wrong patch. 0001 does not apply cleanly on top of the current master. Please check your rebase.
Sorry for the inconvenience, it looks I have sent the first patch again..attached are patches rebased on the current master.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 03/04/2010 01:02 PM, Jakub Hrozek wrote:
On 03/04/2010 06:50 PM, Stephen Gallagher wrote:
Jakub, I think you may have sent the wrong patch. 0001 does not apply cleanly on top of the current master. Please check your rebase.
Sorry for the inconvenience, it looks I have sent the first patch again..attached are patches rebased on the current master.
Patch 0001: Ack
Patch 0002: Nack Can we add: rotate 2 compress
to the logrotate script? I think it would be useful to have the previous two weeks' logs if something went wrong, and our logs compress very well.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 03/08/2010 03:19 PM, Stephen Gallagher wrote:
Patch 0002: Nack Can we add: rotate 2 compress
to the logrotate script? I think it would be useful to have the previous two weeks' logs if something went wrong, and our logs compress very well.
Sure, see attached patch.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 03/08/2010 10:26 AM, Jakub Hrozek wrote:
On 03/08/2010 03:19 PM, Stephen Gallagher wrote:
Patch 0002: Nack Can we add: rotate 2 compress
to the logrotate script? I think it would be useful to have the previous two weeks' logs if something went wrong, and our logs compress very well.
Sure, see attached patch.
Ack, thanks.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 03/08/2010 10:31 AM, Stephen Gallagher wrote:
On 03/08/2010 10:26 AM, Jakub Hrozek wrote:
On 03/08/2010 03:19 PM, Stephen Gallagher wrote:
Patch 0002: Nack Can we add: rotate 2 compress
to the logrotate script? I think it would be useful to have the previous two weeks' logs if something went wrong, and our logs compress very well.
Sure, see attached patch.
Ack, thanks.
Pushed to master and 1-1-0.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Stephen Gallagher