URL: https://github.com/SSSD/sssd/pull/387 Author: amitkumar50 Title: #387: Setting ldap_sudo_include_regexp to false Action: opened
PR body: """ Disable ldap_sudo_include_regexp option by default since this is costly operation for evaluation on ldap server.
Resolves: https://pagure.io/SSSD/sssd/issue/3515 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/387/head:pr387 git checkout pr387
URL: https://github.com/SSSD/sssd/pull/387 Title: #387: Setting ldap_sudo_include_regexp to false
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/387#issuecomment-330194634
URL: https://github.com/SSSD/sssd/pull/387 Title: #387: Setting ldap_sudo_include_regexp to false
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/387#issuecomment-330194632
URL: https://github.com/SSSD/sssd/pull/387 Title: #387: Setting ldap_sudo_include_regexp to false
fidencio commented: """ ok to test """
See the full comment at https://github.com/SSSD/sssd/pull/387#issuecomment-330195910
URL: https://github.com/SSSD/sssd/pull/387 Title: #387: Setting ldap_sudo_include_regexp to false
fidencio commented: """ So, a few things related to this PR: - I would like to see a message in the commit log that could explain as well as the ticket does why this changes has been done; - It's going to be a quite big change of behaviour for whoever is using SSSD and relying on that enabled by default, so I'd do this before 2.0; - I would like to see a good message in our manpage warning whoever wants to use this that this operation is costly; """
See the full comment at https://github.com/SSSD/sssd/pull/387#issuecomment-330196265
URL: https://github.com/SSSD/sssd/pull/387 Title: #387: Setting ldap_sudo_include_regexp to false
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/387 Title: #387: Setting ldap_sudo_include_regexp to false
fidencio commented: """ Oh, now I see that the issue has the tag "break compatibility" and is actually set to 2.0 already. """
See the full comment at https://github.com/SSSD/sssd/pull/387#issuecomment-330198251
URL: https://github.com/SSSD/sssd/pull/387 Title: #387: Setting ldap_sudo_include_regexp to false
jhrozek commented: """ Yes, we can't merge this PR until we start working on the 2.0 milestone and are ready to break compatibility.
That will happen during the F-28 timeframe. """
See the full comment at https://github.com/SSSD/sssd/pull/387#issuecomment-330494930
URL: https://github.com/SSSD/sssd/pull/387 Title: #387: Setting ldap_sudo_include_regexp to false
Label: +postponed until sssd 2.0
URL: https://github.com/SSSD/sssd/pull/387 Title: #387: Setting ldap_sudo_include_regexp to false
jhrozek commented: """ @amitkumar50 do you still plan on updating this PR? """
See the full comment at https://github.com/SSSD/sssd/pull/387#issuecomment-378382497
URL: https://github.com/SSSD/sssd/pull/387 Title: #387: Setting ldap_sudo_include_regexp to false
amitkumar50 commented: """ @jhrozek Yes. Are Only comments at this point are those provided by @fidencio on Sep 18, 2017 """
See the full comment at https://github.com/SSSD/sssd/pull/387#issuecomment-378473492
URL: https://github.com/SSSD/sssd/pull/387 Title: #387: Setting ldap_sudo_include_regexp to false
jhrozek commented: """ Yes, I think only Fabiano's comments need to be addressed """
See the full comment at https://github.com/SSSD/sssd/pull/387#issuecomment-378505643
URL: https://github.com/SSSD/sssd/pull/387 Title: #387: Setting ldap_sudo_include_regexp to false
jhrozek commented: """ Hi @amitkumar50, since this PR has been stalled for quite some time, I'm going to close it. Please feel free to reopen the PR if you plan on addressing the issues that @fidencio brought up. Also, please feel free to work with us on the #sssd IRC channel if you need some help. """
See the full comment at https://github.com/SSSD/sssd/pull/387#issuecomment-390783578
URL: https://github.com/SSSD/sssd/pull/387 Author: amitkumar50 Title: #387: Setting ldap_sudo_include_regexp to false Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/387/head:pr387 git checkout pr387
sssd-devel@lists.fedorahosted.org