On Mon, Jun 24, 2013 at 01:41:44PM +0200, Sumit Bose wrote:
On Mon, Jun 24, 2013 at 11:12:33AM +0200, Jakub Hrozek wrote:
> On Mon, Jun 24, 2013 at 11:04:40AM +0200, Jakub Hrozek wrote:
> > I think we didn't synchronize our changes with Sumit. The SID code
> > doesn't retry correctly when looking up users-or-groups by SID. The
> > attached patch fixes that.
> btw I was wondering whether it would make change to reverse the order of
> searches and first search for groups? It seems to me that during normal
> operation we would be resolving a group SID more frequently..
> Or maybe parallelize the searches because there would always be only two
> (unlike search bases where IIRC we don't have a firm limit)
I think changing the order is a good idea, this would reduce the number
of requests. I think running them in parallel is not needed because this
would always end up with two requests per SID.
Would you like to open a ticket about it, or shall I?
This is fairly easy, but if it misses 1.10.0, I won't cry too much.