On Wed, Jul 10, 2013 at 02:55:42PM +0200, Lukas Slebodnik wrote:
On (09/07/13 23:45), Jakub Hrozek wrote:
>On Thu, Jun 27, 2013 at 07:01:33PM +0200, Jakub Hrozek wrote:
>> On Thu, Jun 27, 2013 at 02:02:44PM +0200, Pavel Březina wrote:
>> > On 06/27/2013 01:09 PM, Ondrej Kos wrote:
>> > >On 06/27/2013 12:48 PM, Pavel Březina wrote:
>> > >>On 06/26/2013 03:16 PM, Ondrej Kos wrote:
>> > >>>Hi,
>> > >>>
>> > >>>Attached find a patch addressing sssd trac issue
>> > >>>https://fedorahosted.org/sssd/ticket/1778
>> > >>>
>> > >>>Ondra
>> > >>
>> > >>The patch works as expected, I have just a comment to debug
message.
>> > >>
>> > >>>+ /* Is a special file */
>> > >>>+ DEBUG(SSSDBG_FUNC_DATA, ("Cannot copy
'%s', it is a special
>> > >>>file.\n",
>> > >>>+ src_ent_path));
>> > >>
>> > >>"Cannot copy" looks like this is something unexpected, an
error. I'd
>> > >>recommend to use something like "'%s' is a special
file, skipping...".
>> > >>
>> > >
>> > >Thanks for the review, new patch is attached.
>> > >
>> > >Ondra
>> >
>> > Ack.
>>
>> Nack for 1.10, we can't include man page changes at this point, we're
string
>> frozen. When 1.11 branches off (probably tomorrow), I'll be able to push
>> this patch to 1.11 but for inclusion in 1.10 please resend without the
>> man page change.
>
>However, ack for 1.11 (master). Also attached is the same patch just
>with the manpage hunk removed. I think it is good to go for 1.10 but I'd
>like someone to ack it for sanity reasons.
Patch is the same like Ondra's version, only changes to manual page was
removed.
ACK for 1.10.
LS
Pushed to sssd-1-10