On Thu, Mar 07, 2013 at 07:21:18PM +0100, Jakub Hrozek wrote:
On Wed, Mar 06, 2013 at 10:47:45AM -0500, Stephen Gallagher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Wed 06 Mar 2013 09:02:44 AM EST, Jakub Hrozek wrote:
>
> >> +# Determine the architecture of the platform we're running on
> >> +SSS_ARCH=`uname -p` + +# Determine the lib and libdir locations
> >> +SSS_LIB=`rpm --eval %{_lib}` +SSS_LIBDIR=`rpm --eval
> >> %{_libdir}` +
> >
> > I personally prefer $() to backticks, but that may be just my
> > preference.
> >
>
> Sure, changed.
>
> ...
>
> >> +# Install the built sources to the current system, cleaning up
> >> the LDB modules +# and making sure that the NSS and PAM modules
> >> have the right SELinux context. +alias sssinstall='sudo make
> >> -j$PROCESSORS install && sudo rm -f
> >> /usr/lib64/ldb/modules/ldb/memberof.la && sudo restorecon -v
> >> /usr/lib64/libnss_sss.so.2 /usr/lib64/security/pam_sss.so'
> >
> > ^^^ I think SSS_LIB should be used to remove the memberof module
> > instead.
> >
> > The rest looks good to me as far as contrib/ stuff goes.
> >
>
>
> Good catch, fixed.
>
>
> I made a couple other tweaks as well:
> * I reflowed the content so it fits in 80 characters
> * I modified the 'remake' alias to consume the 'chmake' alias
> * I stopped passing -Werror by default (since on F18 right now this
> fails because of krb5 issues). I added a note that it's recommended to
> add SSS_WERROR=-Werror to .bashrc
Ack, I will just squash in the attached patch so that the example can be
just cut-n-pasted.
Pushed to master.