On 21 Jul 2014, at 21:42, Lukas Slebodnik <lslebodn(a)redhat.com>
> On (21/07/14 14:08), Jakub Hrozek wrote:
>> On Mon, Jul 21, 2014 at 01:55:20PM +0200, Jan Cholasta wrote:
>>> On 18.7.2014 06:41, William wrote:
>>>>> Ignore that last patch, I messed up and didn't include a .h file.
>>>>> is the fixed patch.
>>>> This new patch seems to be based on some older version of the patch, it
>>>> uses wrong option name, sysdb_update_ssh_host still has the confdb
>>>> argument, etc.
>>> Fixed, and fixed the documentation into the xml file, removed the
>>> references to the .pot file.
>> I don't see any of the requested fixes in the patch.
>> See attachment for fixed patch. I also did a few additional tweaks to make
>> the patch work when SSSD is updated from a previous version and when
>> building without SSH bits.
Sorry about this: seems towards the end i messed up my gif repo as i rebased on the wrong
branch, which led to this issue. Thanks for your patience however.
> Awesome thank you, I guess some of us need to review the patch now
> you're also an author. And thanks for keeping the attribution to
> William, but if you like you can also split the patch into two so you
> have credit for your work.
> William, can you help us test the patch?
Sure, happy to help.
Sorry, explain for me? Im relatively new to this process.
sssd-devel mailing list