>From 0fac335ca07f8617edd9f07921b6e6a9f0162534 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Wed, 25 Apr 2012 17:15:21 +0200 Subject: [PATCH 2/4] PROXY: return correct return codes We were reporting on the value of "status" instead of "ret'. We also didn't set ret to EOK in cases group contained no members. --- src/providers/proxy/proxy_id.c | 16 +++++++++------- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/providers/proxy/proxy_id.c b/src/providers/proxy/proxy_id.c index e1325b74d3f97cde38e182ec659f50aed93e185a..8a8c7ca80d1b24e53c3d55d06564e719a069642a 100644 --- a/src/providers/proxy/proxy_id.c +++ b/src/providers/proxy/proxy_id.c @@ -143,8 +143,8 @@ done: talloc_zfree(tmpctx); if (ret) { DEBUG(SSSDBG_OP_FAILURE, - ("proxy -> getpwnam_r failed for '%s' <%d>\n", - name, status)); + ("proxy -> getpwnam_r failed for '%s' <%d>: %s\n", + name, ret, strerror(ret))); } return ret; } @@ -334,7 +334,8 @@ done: talloc_zfree(tmpctx); if (ret) { DEBUG(SSSDBG_CRIT_FAILURE, - ("proxy -> getpwuid_r failed for '%d' <%d>\n", uid, status)); + ("proxy -> getpwuid_r failed for '%d' <%d>: %s\n", + uid, ret, strerror(ret))); } return ret; } @@ -656,6 +657,7 @@ static errno_t proxy_process_missing_users(struct sysdb_ctx *sysdb, } } + ret = EOK; done: talloc_free(tmp_ctx); return ret; @@ -848,8 +850,8 @@ done: talloc_zfree(tmpctx); if (ret) { DEBUG(SSSDBG_OP_FAILURE, - ("proxy -> getgrnam_r failed for '%s' <%d>\n", - name, status)); + ("proxy -> getgrnam_r failed for '%s' <%d>: %s\n", + name, ret, strerror(ret))); } return ret; } @@ -917,8 +919,8 @@ done: talloc_zfree(tmpctx); if (ret) { DEBUG(SSSDBG_OP_FAILURE, - ("proxy -> getgrgid_r failed for '%d' <%d>\n", - gid, status)); + ("proxy -> getgrgid_r failed for '%d' <%d>: %s\n", + gid, ret, strerror(ret))); } return ret; } -- 1.7.7.6