>From a43fa832744fd3030faa413aff712de0a282fac1 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Wed, 25 Apr 2012 16:45:06 +0200 Subject: [PATCH 1/4] SSS_DEBUGLEVEL: silence analyzer warnings Errno was returned instead of ret. The other hunk removes return code from fread - it is not needed, the NULL termination of the string is ensured by initializing the buffer. --- src/tools/sss_debuglevel.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/tools/sss_debuglevel.c b/src/tools/sss_debuglevel.c index 83be144422eed47ef013b9d5bac837f10a6a9b6e..603ae16698dcca29024ea845f1bbda8d3cfc188d 100644 --- a/src/tools/sss_debuglevel.c +++ b/src/tools/sss_debuglevel.c @@ -218,7 +218,7 @@ errno_t send_sighup() ret = errno; DEBUG(SSSDBG_CRIT_FAILURE, ("Could not send SIGHUP to process %d: %s\n", pid, strerror(errno))); - return errno; + return ret; } return EOK; @@ -333,7 +333,7 @@ errno_t get_sssd_pid(pid_t *out_pid) goto done; } - ret = fread(pid_str, sizeof(char), MAX_PID_LENGTH * sizeof(char), pid_file); + fread(pid_str, sizeof(char), MAX_PID_LENGTH * sizeof(char), pid_file); if (!feof(pid_file)) { /* eof not reached */ ret = ferror(pid_file); @@ -347,6 +347,7 @@ errno_t get_sssd_pid(pid_t *out_pid) goto done; } + pid_str[MAX_PID_LENGTH-1] = '\0'; *out_pid = parse_pid(pid_str); if (*out_pid == 0) { DEBUG(SSSDBG_CRIT_FAILURE, -- 1.7.7.6