>From 7fc35eb3420f0a79e1a336dfd96c4bdc8073827f Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Tue, 2 Sep 2014 15:26:11 +0200 Subject: [PATCH] refcount-tests: Do not force to run test in CK_FORK mode There was an access to uninitialised data in old version of libcheck when tests were executed in fork mode. ==2842== Syscall param timer_create(evp) points to uninitialised byte(s) ==2842== at 0x977FE72: timer_create@@GLIBC_2.3.3 (timer_create.c:82) ==2842== by 0x4E3647B: srunner_run (in /usr/lib64/libcheck.so.0.0.0) ==2842== by 0x401616: main (refcount-tests.c:233) ==2842== Address 0xffefff460 is on thread 1's stack This bug is already fixed in check-0.9.14, but we want to execute tests with valgrind on older platforms. The refcount test had hardcoded CK_FORK in source code and therefore it could not be overwritten with environment variable, which we use in CI script. --- src/tests/refcount-tests.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/tests/refcount-tests.c b/src/tests/refcount-tests.c index 7fb398e7aa931009c8957488bf4710cc3b33087b..6d569994e0a3cfb188f75b9c92aada963191c1ca 100644 --- a/src/tests/refcount-tests.c +++ b/src/tests/refcount-tests.c @@ -228,7 +228,6 @@ int main(int argc, const char *argv[]) suite = create_suite(); sr = srunner_create(suite); - srunner_set_fork_status(sr, CK_FORK); /* If CK_VERBOSITY is set, use that, otherwise it defaults to CK_NORMAL */ srunner_run_all(sr, CK_ENV); failure_count = srunner_ntests_failed(sr); -- 2.1.0