-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/21/2010 03:32 PM, Stephen Gallagher wrote:
Nack. If you're going to add the option to upgrade_config.py, you
also
need to check for _srv_ in the ldap_uri, ipa_server and krb5_kdcip.
In the failover code, please don't use "domain". It's too easy to
confuse with SSSD domains. Please use dns_domain.
+ domptr = strchr(fqdn, '.');
+ domptr++;
+ if (!domptr) {
+ *domain = talloc_strdup(mem_ctx, fqdn);
This is a bug, if there is no '.' in the string, you will return NULL
and then increase it by one.
Also, you should check if domptr+1 (after the dot) is a NULL-terminator
before calling talloc_strdup(just to be safe, in case we somehow got
'hostname.' back as a reply from a broken DNS server)
Otherwise, this looks pretty good.
Thanks for the review, a new patch is attached.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkwg2s0ACgkQHsardTLnvCXGfgCcCsDr6OD2e5f7HmazxuLJ9L3C
ky4AoJI4/xmf9b2wd8JjNBGoqx+YaFgl
=9iv5
-----END PGP SIGNATURE-----