On Wed, Jun 18, 2014 at 12:47:50PM +0200, Lukas Slebodnik wrote:
> On (05/06/14 16:44), Pavel Reichl wrote:
> >On Wed, 2014-06-04 at 17:34 +0200, Sumit Bose wrote:
> >> On Wed, Jun 04, 2014 at 04:40:41PM +0200, Pavel Reichl wrote:
> >> > Hello,
> >> >
> >> > while working on
> >> >
https://fedorahosted.org/sssd/ticket/2056
> >> > I noticed this already applied patch
> >> >
http://fedorapeople.org/cgit/sbose/public_git/sssd.git/commit/?id=48eb2ca...
> >> >
> >> > What's the best course of action now?
> >> > 1) Simply close the ticket?
> >> >
> >> > 2) Add sysdb_attrs_add_lower_case_string and make
> >> > sysdb_attrs_add_lc_name_alias to utilize it? (attached patch does so)
> >>
> >> I would prefer 2.
> >
> >Great, so I don't have to amend attached patch.
> >PR
> >
>
> Sumit,
> do you have any other comments?
> Will you ACK this patch or should anyone else?
ah, sorry, yes it was an ACK from my side.
bye,
Sumit
Pushed to master: 21fc2ea7d4a9944582ffd4d11500faf4bddae835
It would be nice if you could also add a unit test, but a separate patch
for that is OK I guess.