Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
If a DNS lookup fails to return an IPv4 address for a hostname, we
will attempt to look up an IPv6 address before returning a failure.
Note: this only ensures that the async resolver identifies the correct
address. Currently, there is still a bug in the LDAP code somewhere
that prevents our connecting to an LDAP server over IPv6. I am looking
into this separately.
I made the review yesterday, but forgot to reply, sorry:
+ }
+ else
+ tevent_req_done(req);
Just a style issue, please move else up one line and add { } around
tevent_req_done(req);.
+ state->status = status;
+ state->timeouts = timeouts;
+
if (status != ARES_SUCCESS)
tevent_req_error(req, return_code(status));
else
Since you are already here, can you please add {} here as well?
ACK, but please address these minor details before pushing, thanks.
Martin