On Wed, Aug 13, 2014 at 02:31:36PM -0400, Yassir Elley wrote:
I have one nitpick.
+ ret = sysdb_gpo_store_gpo(test_ctx->domain,
+ test_guid, 1, 5, 0);
+ fail_if(ret != EOK, "Could not store a test GPO");
+ ret = sysdb_gpo_get_gpos(test_ctx, test_ctx->domain, &result);
+ fail_if(ret != EOK, "GPOs not in cache before store op");
+ fail_if(result == NULL);
+ fail_if(result->count != 1);
In the above snippet, you store a gpo and then attempt to retrieve all gpos. The error
message after sysdb_gpo_get_gpos says "GPOs not in cache before store op",
whereas it should really say "GPOs not in cache after store op".
Otherwise, the code looks good!
Thanks for catching that, a new patch is attached.