On Wed, Jan 05, 2011 at 04:03:38PM -0500, Dmitri Pal wrote:
Stephen Gallagher wrote:
> On 01/05/2011 03:40 PM, Dmitri Pal wrote:
> >>>>> 0003--BUILD-Allow-trace-per-component.patch <- This patch
> >> tracing
> >>>>> per component
> >>>> Nack. Requiring a file doesn't make sense. Just add
> >>>> --enable-trace-collection etc. flags.
> >>> This is exactly what I did not like to do and tried to avoid. It
> is more
> >>> code on the configure script, more checks and less convenient to
> turn on
> >>> and off becuase you can run the same configure command with one switch
> >>> enabled from history and do "touch trace" & "rm
trace" as needed
> in the
> >>> directory you need.
> >>> Saves a lot of typing for me :-)
> >>> If you do not like the patch I will have to keep it as private
> patch as
> >>> it is more convenient for me during development than the flags.
> >> I still vote nack, as I don't like the approach.
> > So this is the dead lock becuase I like the approach and do not like
> > yours. How we are going to resolve it?
> Ultimately, it's your project, not mine. You have commit privilege and
> full discretion on when to use it. You asked for my review comments. You
> don't have to listen to them :)
Nack. I think we need to come to some terms and find consensus. I will
definitely not push it over your head using my privilege.
I agree that what you suggest is logical and consistent with how things
are done. The problem is that it does not help me much.
I will keep patch in my tree for now.
To enlarge the quorum I throw in my opinion here. In general I agree
with Stephen because the file approach is quite unusual and needs to be
well documented so that other developers can use it. You might also want
to use $builddir instead of $srcdir to allow a separate build directory.
But I would like to suggest another approach which might be even easier
to use. You can introduce a make target like 'trace' or 'devel' which
will build everything with tracing enabled. This way you do not even
have to rerun configure to enable tracing.