On Thu, May 22, 2014 at 04:01:31PM +0200, Jakub Hrozek wrote:
> >> ACK.
> >>
> >> Although I do wonder if all interfaces should have the properties
> >> interface in their introspect data unconditionally. I guess pretty much
> >> any infopipe interface will have DBus Properties ... so this is fine for
> >> now.
> >>
> >> Stef
> >
> > I was wondering that as well and wasn't sure what's the best practice
in
> > the DBus world. I can only add the interface to Introspection if there
> > are properties in the meta, if that's what you'd prefer.
> >
> > My reasoning was that you can always send the Get method to the
> > interface, even if there are no properties, the sbus handler would just
> > kick you out.
>
> Makes sense ... and that's likely how it's implemented in a lot of
> places. Haven't checked.
>
> Stef
OK, I will keep the patches as they are for now.
For what it's worth, I checked systemd when I implemented the patch as
systemd is one of the few projects that implement a DBus interface
without using glib.
Thanks a lot for the review, Stef, much appreciated!
Pushed all to master:
0d8fbc2cb822b4fef90588ca368ceb883b8379f2
c5a592920fab217fdb3aaa897e68f5643de88dc4
5de968e80ade1c02d1907834dcff95e9fc9ad10a
58229439447d5617913a5a2e173b78105c694842
90e04eae7e54ec892a6f239783df94dab5d1ed9a
1319e71fd1680ca4864afe0b1aca2b8c8e4a1ee4
e412c809508be9cdd30da679b92ed9f7292357e9
f2ea63e48812b042d36ac8357f0cb13b2f2184fe
e871517a0bfb806cb2fddc76ff2f59360437a73c