On 09/01/2014 01:47 PM, Nikolai Kondrashov wrote:
Hi Jakub, Michal,
On 08/09/2014 09:26 PM, Nikolai Kondrashov wrote:
> Here is the fifth version of the patch adding CI scripts.
This is the version of CI patches I would like merged, when you'll find
time
to review them.
Thank you.
Nick
Hi,
I have some comments.
1. Valgrind:
The valgrind check needs some enhancements. Currently the results of
this step are just ignored (the test suite fails and this failure is
ignored). In the script there is commnet:
# Ignored until issues found by Valgrind are fixed
But this will NEVER happen.
If we want to get something out of this step than we need
to know at least:
a) how many tests failed,
b) how many valgrind errors were detected
and this information must be printed on the screen (not hidden in the
logs, otherwise everyone will just ignore it). This way, we will know,
that no new errors/failures were introduced. And if the number rises
than we check if it is a false positive or not in the logs.
2. Clang-static analyser:
Similar to the valgrind step. We at least need some numbers to be
printed on the screen (number of problems detected), otherwise this
step will be very little useful and basically will just make the
whole "check" longer.
3. More options:
I would like to have possibility to disable/enable specific parts.
The -e/-m/-r flags are IMO not sufficient (for example as long as we
do not fix 1 and 2, I would like to disable/not enable these parts
using some argument)
The above things can be fixed as separate tickets so I am basically
OK with pushing it as-is and enhancing it later.
Michal