On Tue, Oct 20, 2009 at 07:20:51PM -0400, Simo Sorce wrote:
On Tue, 2009-10-20 at 14:24 +0200, Sumit Bose wrote:
> + dummy = dp_opt_get_cstring(opts, KRB5_CHANGEPW_PRINC);
> + if (strchr(dummy, '@') == NULL) {
> + value = talloc_asprintf(opts, "%s@%s", dummy, realm);
> + if (value == NULL) {
> + DEBUG(7, ("talloc_asprintf failed.\n"));
> + return ENOMEM;
> + }
Same here too.
Please always check what you get back.
Simo.
ok, I've added checks where needed. New patches are attached.
bye,
Sumit