On 05/07/2010 10:24 AM, Dmitri Pal wrote:
Stephen Gallagher wrote:
> On 05/06/2010 06:33 PM, Dmitri Pal wrote:
>
>>
>> And then you do not need enum that looks a bit ugly here...
>>
>> At least this gives the idea of what I mean...
>>
>
> I think I was overtired yesterday. The attached patch should be more
> sane.
>
This seems much better, so "visual" ack - I did not try to apply it.
Something is not working for my git repo...
git-remote update hanged... investigating
One comment:
Shouldn't it be "User lookup failed" instead of "Lookup users
failed"
and "Group lookup failed" instead of "Lookup groups failed".
Sure, why not. What's one more revision? :)
--
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/