On 04/11/2016 11:43 AM, Jakub Hrozek wrote:
On Fri, Apr 08, 2016 at 07:31:59PM +0300, Nikolai Kondrashov wrote:
> On 04/06/2016 02:06 PM, Sumit Bose wrote:
>> sorry for the delay. The patch looks good in general and is working as
>> expected. Currently the environment variable is set unconditionally which
>> is good for testing but it might be irritating for some users that there
>> is a new environment variable they do not know about and might be useless
>> for them. Would it be possible to set the variable only if tloc is
>> enabled?
>
> Sure, it should be possible. However, we don't have any "tlog enabling"
so far
> and my impression was that it's undesirable at this stage. Jakub, what are
> your thoughts on this?
I guess we could only enable the new variable if the shell was tlog-rec,
since the variable is tlog-specific anyway.
I would like to avoid this kind of special condition. It is really hidden,
would require explicit documentation and won't work if tlog-rec is renamed.
I'd rather have an explicit option.
Nick