On Tue, 5 Oct 2010 16:50:55 -0400
Simo Sorce <ssorce(a)redhat.com> wrote:
On Tue, 05 Oct 2010 19:10:40 +0200
Jakub Hrozek <jhrozek(a)redhat.com> wrote:
> [PATCH 1/2] sysdb interface for adding fake groups
> Adds a sysdb_add_fake_group_send() call that adds an expired group
> entry.
>
> [PATCH 2/2] Save dummy groups to cache during initgroups
> When performing initgroups/getgrouplist on RFC2307, add fake group
> entries for those groups that are not cached already. That way,
> complete group membership is returned without saving complete group
> objects.
>
It makes me a bit nervous to create "fake groups" which are not really
fake and have a gidnumber = 0
But we always treat 0 as something we can't return, so it should be
good enough.
Ack.
Sorry, retiring my ack for a minor issue.
If these are fake groups it makes no sense to be able to pass in the
group GID. We should have in the header a FAKE_GID_NUMBER definition
and just hardcode that we assign that macro to the gidnumber.
So can you please change the sysdb_add_fake_group_send() interface to
*not* have an argument for the gid ?
Simo.
--
Simo Sorce * Red Hat, Inc * New York