On 01/13/2014 02:53 PM, Stephen Gallagher wrote:
On 01/13/2014 01:42 PM, Lukas Slebodnik
wrote:
> ehlo,
> attached patch addresses ticket #2193
> I have just a question about refarray/libref_array.sym There
is
> extern function ref_array_debug, which is not defined in
public
> header file (not exposed in public API), but it is used in
> ref_array unit tests. It needs to be in global section
because
> linker with fail to find symbol. Should I add any comment to
the
> file libref_array.sym or does anyone better solution?
If this isn't a public API and isn't used except by the unit test,
it
should probably not be built as part of the library. It should
probably be part of the unit test.
IMO this is conceptually wrong.
Unit test emulates external use of the library. Unit test uses only
public header and not private headers if any.
If we put debug function in the unit test we will expose internal of
the library that should not be know outside.
I always view unit tests as example of use. If we show that it is OK
to include private headers people would include private headers and
try to access internal structures directly.
Putting it into a separate module is probably the cleanest solution
but IMO too much overhead.
>
_______________________________________________
> sssd-devel mailing list
> sssd-devel@lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
--
Thank you,
Dmitri Pal
Sr. Engineering Manager for IdM portfolio
Red Hat Inc.
-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/