On Fri, Oct 12, 2012 at 09:53:58AM +0200, Sumit Bose wrote:
- I didn't want to change too much existing code in a minor
release
Without looking too closely at the patches so far, I agree with this
approach.
- I think all nss_cmd_get[ug]id* requests in nsssrv_cmd.c are
looking
for some heavy refactoring. I think with a reasonable amount of of
abstraction all user and group by-name and by-uid requests can be
handled in a single cond path. I haven't looked much at the other, but
I expect that there is room for improvement, too. I others think this
is a valuable task, too, maybe someone can start this soon, so that we
have it ready early in the 1.10 development cycle so that other
patches touching nsssrv_cmd.c can be written on top of the refactored
version.
I was thinking the same and started the refactoring some time ago
already, check out the branch "refactor" in my fedorapeople repo:
http://fedorapeople.org/cgit/jhrozek/public_git/sssd.git/log/?h=refactor
For instance the patch "Generic getent_{send,recv}".
But then it got too late in the release cycle and we were all too busy,
so the patches probably don't even apply anymore. It would be great to get
back to the refactoring in the 1.10 cycle.