>From 39a805910ccf1c42ecf5b2eb1a137ea50967fbac Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Mon, 7 Jul 2014 21:15:12 +0200 Subject: [PATCH 1/7] PROVIDERS: Add ldap_common.h to opts.h of each provider the opts.h files were consuming some #defines from ldap_common.h (such as SSS_LDAP_SRV_NAME) without including ldap_common.h. That's bad practice and break programs that wish to just include the opts.h header. --- src/providers/ad/ad_opts.h | 1 + src/providers/ipa/ipa_opts.h | 1 + src/providers/ldap/ldap_opts.h | 1 + 3 files changed, 3 insertions(+) diff --git a/src/providers/ad/ad_opts.h b/src/providers/ad/ad_opts.h index 8f6ce7e1e9cc3906044c6d8eaa8b4c42e038b57b..b80aaddf29b7fb236d89bfb4e148bba7aeeecd14 100644 --- a/src/providers/ad/ad_opts.h +++ b/src/providers/ad/ad_opts.h @@ -26,6 +26,7 @@ #include "src/providers/data_provider.h" #include "db/sysdb_services.h" #include "db/sysdb_autofs.h" +#include "providers/ldap/ldap_common.h" struct dp_option ad_basic_opts[] = { { "ad_domain", DP_OPT_STRING, NULL_STRING, NULL_STRING }, diff --git a/src/providers/ipa/ipa_opts.h b/src/providers/ipa/ipa_opts.h index 0b39b8c5adb61617c90c1b79a45d350afc3084c8..d7c2b189fad57cb60c29b56c5e351a46070349e2 100644 --- a/src/providers/ipa/ipa_opts.h +++ b/src/providers/ipa/ipa_opts.h @@ -29,6 +29,7 @@ #include "db/sysdb_autofs.h" #include "db/sysdb_services.h" #include "db/sysdb_selinux.h" +#include "providers/ldap/ldap_common.h" struct dp_option ipa_basic_opts[] = { { "ipa_domain", DP_OPT_STRING, NULL_STRING, NULL_STRING }, diff --git a/src/providers/ldap/ldap_opts.h b/src/providers/ldap/ldap_opts.h index f4e18d94942ded72cd5dade585cc4200b1d136da..adf200caa90b51e3e459e01251340c85ec2f518b 100644 --- a/src/providers/ldap/ldap_opts.h +++ b/src/providers/ldap/ldap_opts.h @@ -28,6 +28,7 @@ #include "db/sysdb_sudo.h" #include "db/sysdb_autofs.h" #include "db/sysdb_services.h" +#include "providers/ldap/ldap_common.h" struct dp_option default_basic_opts[] = { { "ldap_uri", DP_OPT_STRING, NULL_STRING, NULL_STRING }, -- 1.9.3