On Tue, Mar 7, 2017 at 4:11 AM, Nikolai Kondrashov <> wrote:
On 03/06/2017 09:34 PM, Dan Lavu wrote:
Since we last spoken, here is an update patch for review. Adding an optional
ssl parameter to the DS class. When enabled, right now the tests fail
because SSL is not configured properly on the client, but I'll get to that
in my next patch?

Glad to see your progress!

Before I proceed with everything else, why don't you just let the DS accept a
CA parameter as well as an SSL port?

Like this:

    def __init__(self, dir, port, base_dn, admin_rdn, admin_pw, ssl_port=None, ca=None):
        # ...
        self.ssl_port = ssl_port = ca
        # ...

And then perhaps make it set up the SSL socket if the port is passed, in *addition*
to the regular socket.

I.e. have this in the constructor:

    self.ldap_url = "ldap://localhost:" + str(self.port)
    if self.ssl_port:
        self.ldaps_url = "ldaps://localhost:" + str(self.ssl_port)

sssd-devel mailing list --
To unsubscribe send an email to