----- Original Message -----
From: "Jakub Hrozek" <jhrozek(a)redhat.com>
Sent: Wednesday, January 21, 2015 3:55:24 PM
Subject: Re: [SSSD] [PATCH] sbus: use hard coded getters instead of generated
On Tue, Jan 20, 2015 at 09:54:56PM +0100, Pavel Březina wrote:
> On 01/05/2015 02:04 PM, Pavel Březina wrote:
> >I wrote most of this patch during the Christmas break.
> >It removes the codegen code for generating property getters (invokers to
> >be precise) and create hard coded ones. It also add a simple and general
> >purpose GetAll invoker. The reason and justification is in the commit
> >Keeping method generated invokers makes sense, since each method can
> >have different number of arguments with different type.
> >I hope you like it.
> Rebased on top of latest respin of "[PATCHES] sbus: support multiple
> interfaces on single object path".
I agree with the general intention, especially considering the removal
of the reply as functions in the second patch, but I really dislike
removing 800 lines of tests without a proper substitute.
There is not test remove, it is just generated code that changed.
Also, the 30+ lines long macros are impossible to debug, please
them to functions. Given that callers of the macros usually just call
the single line, you can just return the new function.
The reason it is a macro is to change the type of variable and handler. It is not possible
to do it with a function.