On 08/24/2016 05:25 PM, Fabiano Fidêncio wrote:
Petr,
On Wed, Aug 24, 2016 at 4:22 PM, Petr Cech <pcech(a)redhat.com> wrote:
> Hello,
>
> I am fighting with adding new option to sssd.conf.
> I slowly running out of breath.
>
> I know proxy could be id, auth or chpass provider. I don't know
> where is the right place for my option. And the second issue is
> it breaks test for SSSD config. :-(
>
> Is there anyone who would like to join to the fight? Please,
> see attached patch.
I could spot 1 issue and one possible issue with your patch.
Let me paste the (possible) problematic parts here:
> diff --git a/src/config/SSSDConfig/__init__.py.in
b/src/config/SSSDConfig/__init__.py.in
> index
b3f04ac26309bb5b518fb87cd0dae2962e853179..50917322da74211a54db69fee05589bdddaebd33 100644
> --- a/src/config/SSSDConfig/__init__.py.in
> +++ b/src/config/SSSDConfig/__init__.py.in
> @@ -435,6 +435,7 @@ option_strings = {
> 'proxy_fast_alias' : _('Whether to look up canonical group name from
cache if possible'),
>
> # [provider/proxy/auth]
> + 'proxy_max_children' : _('The number of preforked proxy
children.'),
> 'proxy_pam_target' : _('PAM stack to use')
> }
As far as I understand from the ticket, proxy_max_children should be a
global option for proxy, so you should put it ander [provider/proxy]
and not under [provider/proxy/auth].
> diff --git a/src/config/etc/sssd.api.d/sssd-proxy.conf
b/src/config/etc/sssd.api.d/sssd-proxy.conf
> index 89a6503..96e2d4a 100644
> --- a/src/config/etc/sssd.api.d/sssd-proxy.conf
> +++ b/src/config/etc/sssd.api.d/sssd-proxy.conf
> @@ -1,11 +1,9 @@
> -[provider/proxy]
> -
> [provider/proxy/i
> proxy_lib_name = str, None, true
> proxy_fast_alias = bool, None, true
>
> [provider/proxy/auth]
> proxy_pam_target = str, None, true
> +proxy_max_children = int, None, false
>
> [provider/proxy/chpass]
> -
On this part I'm pretty sure you don't want to remove [provider/proxy]
neither the last line of the file.
And as far as I understand from the option you're trying to add, it
should be added under [provider/proxy].
With these 2 changes "make check" passes again and I guess it's enough
for what you're trying to achieve.
Here you can see my changes on top of your changes:
[ffidenci@cat x86_64]$ git diff
diff --git a/src/config/SSSDConfig/__init__.py.in
b/src/config/SSSDConfig/__init__.py.in
index 5091732..9076dd2 100644
--- a/src/config/SSSDConfig/__init__.py.in
+++ b/src/config/SSSDConfig/__init__.py.in
@@ -430,12 +430,14 @@ option_strings = {
'default_shell' : _('Default shell, /bin/bash'),
'base_directory' : _('Base for home directories'),
+ # [provider/proxy]
+ 'proxy_max_children' : _('The number of preforked proxy
children.'),
+
# [provider/proxy/id]
'proxy_lib_name' : _('The name of the NSS library to use'),
'proxy_fast_alias' : _('Whether to look up canonical group name
from cache if possible'),
# [provider/proxy/auth]
- 'proxy_max_children' : _('The number of preforked proxy
children.'),
'proxy_pam_target' : _('PAM stack to use')
}
diff --git a/src/config/etc/sssd.api.d/sssd-proxy.conf
b/src/config/etc/sssd.api.d/sssd-proxy.conf
index 96e2d4a..09bf82a 100644
--- a/src/config/etc/sssd.api.d/sssd-proxy.conf
+++ b/src/config/etc/sssd.api.d/sssd-proxy.conf
@@ -1,9 +1,12 @@
+[provider/proxy]
+proxy_max_children = int, None, false
+
[provider/proxy/id]
proxy_lib_name = str, None, true
proxy_fast_alias = bool, None, true
[provider/proxy/auth]
proxy_pam_target = str, None, true
-proxy_max_children = int, None, false
[provider/proxy/chpass]
+
I hope it helps!
Best Regards,
--
Fabiano Fidêncio
Hi Fabiano,
thank you for help. You was right with section
[provider/proxy].
And I hit little issue with last white line in file.
My IDE did some automagic.
The entry in man page is really short. Please, if you have any idea,
share it.
Regards
--
Petr^4 Čech