URL:
https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
pbrezina commented:
"""
```
/home/pbrezina/workspace/sssd/src/db/sysdb_computer.c: In function
‘sysdb_search_computer’:
/home/pbrezina/workspace/sssd/src/db/sysdb_computer.c:42:20: error: unused variable ‘dn’
[-Werror=unused-variable]
struct ldb_dn *dn;
```
The FIXME in sysdb_set_computer would be an enhancement, but is not
required for this to function.
Can you open a ticket for it then, after the patches are merged? Otherwise it will be
forgotten.
The FIXME in ad_gpo_get_host_sid_retrieval_done is trivial, and not
necessary.
Please address this FIXME and introduce a new option for it. It is really not difficult as
you wrote so I think it can be done as part of this PR.
There is also a crash in sssd_be responder. I setup some GPO, run SSSD and tried to login
as Administrator:
```
warning: Loadable section ".note.gnu.property" outside of ELF segments
Core was generated by `/usr/libexec/sssd/sssd_be --domain ad.vm --uid 0 --gid 0 -d 0x3ff0
--logger=std'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x00007f699b10e647 in ad_gpo_get_host_sid_retrieval_done (subreq=0x0) at
/home/pbrezina/workspace/sssd/src/providers/ad/ad_gpo.c:2150
2150 ret = sysdb_attrs_get_el(reply[0], AD_AT_SID, &el);
Missing separate debuginfos, use: dnf debuginfo-install sssd-common-2.2.0-3.fc29.x86_64
(gdb) bt
#0 0x00007f699b10e647 in ad_gpo_get_host_sid_retrieval_done (subreq=0x0) at
/home/pbrezina/workspace/sssd/src/providers/ad/ad_gpo.c:2150
#1 0x00007f699ac1d924 in sdap_get_generic_done (subreq=0x1bfed80) at
/home/pbrezina/workspace/sssd/src/providers/ldap/sdap_async.c:1961
#2 0x00007f699ac1d219 in generic_ext_search_handler (subreq=0x0, opts=0x1aed450) at
/home/pbrezina/workspace/sssd/src/providers/ldap/sdap_async.c:1778
#3 0x00007f699ac1d63d in sdap_get_and_parse_generic_done (subreq=0x1bb9620) at
/home/pbrezina/workspace/sssd/src/providers/ldap/sdap_async.c:1886
#4 0x00007f699ac1cca3 in sdap_get_generic_op_finished (op=0x1baee10, reply=0x1bd2110,
error=0, pvt=0x1bb9620) at
/home/pbrezina/workspace/sssd/src/providers/ldap/sdap_async.c:1668
#5 0x00007f699ac187ba in sdap_process_message (ev=0x1adb3f0, sh=0x1b5ec00, msg=0x1bc7270)
at /home/pbrezina/workspace/sssd/src/providers/ldap/sdap_async.c:341
#6 0x00007f699ac182e7 in sdap_process_result (ev=0x1adb3f0, pvt=0x1b5ec00) at
/home/pbrezina/workspace/sssd/src/providers/ldap/sdap_async.c:185
#7 0x00007f699ac17f85 in sdap_ldap_next_result (ev=0x1adb3f0, te=0x1be2b10, tv=...,
pvt=0x1b5ec00) at /home/pbrezina/workspace/sssd/src/providers/ldap/sdap_async.c:133
#8 0x00007f69a9cb7e79 in tevent_common_invoke_timer_handler (te=te@entry=0x1be2b10,
current_time=..., removed=removed@entry=0x0) at ../tevent_timed.c:369
#9 0x00007f69a9cb800e in tevent_common_loop_timer_delay (ev=ev@entry=0x1adb3f0) at
../tevent_timed.c:441
#10 0x00007f69a9cb909b in epoll_event_loop_once (ev=0x1adb3f0, location=<optimized
out>) at ../tevent_epoll.c:922
#11 0x00007f69a9cb74bb in std_event_loop_once (ev=0x1adb3f0, location=0x7f69aa1be8a8
"/home/pbrezina/workspace/sssd/src/util/server.c:718") at
../tevent_standard.c:110
#12 0x00007f69a9cb2838 in _tevent_loop_once (ev=ev@entry=0x1adb3f0,
location=location@entry=0x7f69aa1be8a8
"/home/pbrezina/workspace/sssd/src/util/server.c:718") at ../tevent.c:772
#13 0x00007f69a9cb2a8b in tevent_common_loop_wait (ev=0x1adb3f0, location=0x7f69aa1be8a8
"/home/pbrezina/workspace/sssd/src/util/server.c:718") at ../tevent.c:895
#14 0x00007f69a9cb744b in std_event_loop_wait (ev=0x1adb3f0, location=0x7f69aa1be8a8
"/home/pbrezina/workspace/sssd/src/util/server.c:718") at
../tevent_standard.c:141
#15 0x00007f69aa18c41a in server_loop (main_ctx=0x1adb710) at
/home/pbrezina/workspace/sssd/src/util/server.c:718
#16 0x000000000040baaf in main (argc=10, argv=0x7ffdad471268) at
/home/pbrezina/workspace/sssd/src/providers/data_provider_be.c:780
```
Thank you.
@mzidek-rh or @sumit-bose Since I'm goint to PTO would you mind to take over the
review? It looks good code-wise in general, I was not able to test these patches
function-wise due to this crash.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/905#issuecomment-562147931