On Wed, Feb 25, 2015 at 11:20:45PM +0100, Lukas Slebodnik wrote:
I'm not sure we understood each other, I was specifically asking about stabe branch. In master, we would add strict requirements for cmocka 1.0+, convert all tests there and don't run any tests if cmocka 1.0+ is not found.
Agree with strict requirement Agree with converting tests.
See attached patches. CI - http://sssd-ci.duckdns.org/logs/job/9/24/summary.html
In sssd-1-12, we would keep the existing tests untouched and ignore the deprecation warnings. But what if someone submits a patch that needs to be included in sssd-1-12, too but adds a test that is written using cmocka-1.0 API? We could either: a) backport the patch without the test b) backport the patch as-is, but add the Makefile.am part of the patch into a new block that gets executed only if cmocka 1.0 is available. Currently we only have a global HAVE_CMOCKA if-endif.
c) - add strict requirement for cmocka 1.0+ - do not convert tests - ignore warnings caused by deprecated function in cmocka 1.0
Result: * change in stable branch will be small * there will not be problem with backporting new tests * makefile will not be poluted with another if else block * if cmocka-1.0+ is not available then cmocka tests will not be executed
Distributions: arch - does not run tests at all opensuse - does not run tests at all gentoo - does not run cmocka test debian - cmocka tests are disabled (due to failueres on some arch) [1] ubuntu - cmocka tests are disabled (due to failueres on some arch) fedora - cmocka-1.0 will be available epel{6,7} - cmocka-1.0 will be available
[1] http://anonscm.debian.org/cgit/pkg-sssd/sssd.git/commit/?id=ea1575581b86cd32...
cmocka is an optional dependency. So I don't think we need to complicate Makefile in stable branches with with cmocka < 1.0 and cmocka >= 1.0.
I think we should just push the first and second patch to sssd-1-12, then.