On (09/03/16 18:47), Jakub Hrozek wrote:
On Wed, Mar 09, 2016 at 10:06:38AM +0100, Pavel Březina wrote:
> I'm fine either way.
OK, see the attached patch.
From ea49df6b0816845ec667392a170f4176e759731f Mon Sep 17 00:00:00
2001
From: Jakub Hrozek <jhrozek(a)redhat.com>
Date: Wed, 9 Mar 2016 18:44:43 +0100
Subject: [PATCH] LDAP: Remove misleading debug message
The ENOENT message is already handled in sdap_attrs_get_sid_str() and
the debug message in the LDAP provider relied on name which was not
known at the time.
---
src/providers/ldap/sdap_async_groups.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/src/providers/ldap/sdap_async_groups.c
b/src/providers/ldap/sdap_async_groups.c
index 3ccf7deb53d365a106cd18af1835f527424d5bf3..68acd32aec3681eae7ef703050efff0c874112e8
100644
--- a/src/providers/ldap/sdap_async_groups.c
+++ b/src/providers/ldap/sdap_async_groups.c
@@ -537,10 +537,6 @@ static int sdap_save_group(TALLOC_CTX *memctx,
sss_strerror(ret));
goto done;
}
- } else if (ret == ENOENT) {
- DEBUG(SSSDBG_TRACE_ALL, "objectSID: not available for group [%s].\n",
- group_name);
- sid_str = NULL;
} else {
DEBUG(SSSDBG_MINOR_FAILURE, "Could not identify objectSID: [%s]\n",
sss_strerror(ret));
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
After this patch we will see SSSDBG_MINOR_FAILURE.
Which is worse than "objectSID: not available for group" without any name.
LS