Hello,

I do not like either of the versions of the patch.
It is OK to use path_concat instead of snprintf. The whole point of not using it was to simplify the code and not have to check yet another error clause. But using path_concat is fine.
The thing that I do not like is that in the current code it is done in both branches of the if clause.
I think we should move the path_concat call above the
  /* Match names */
        match = ini_aug_match_name(entry->d_name, ra_regex);
Logic would be:
- create the full path
- check errors
- call the function above
- use full name in both clauses as needed
 
That approach IMO would be cleaner.

-- 
Thank you,
Dmitri Pal

Engineering Director, Identity Management and Platform Security
Red Hat, Inc.