lslebodn commented on a pull request
"""
On (07/09/16 07:18), mzidek-rh wrote:
Hi,
This PR is blocked by PR#16 (TOOLS: sss_groupshow did not work). It includes fix for the
ticket
https://fedorahosted.org/sssd/ticket/3178.
Michal
You can view, comment on, or merge this pull request online at:
https://github.com/SSSD/sssd/pull/18
6th patch
src/tools/tools_mc_util.c
if (ret != EOK) {
DEBUG(SSSDBG_MINOR_FAILURE, "Malformed DN [%s]? Skipping\n",
(const char *) el->values[i].data);
- talloc_free(parent_name);
+ talloc_free(parent_internal_name);
continue;
}
- ret = sss_mc_refresh_group(parent_name);
- talloc_free(parent_name);
+ ret = sss_parse_internal_fqname(tmpctx, parent_internal_name,
+ &parent_shortname, NULL);
we should use sss_output_name here
+ if (ret != EOK) {
+ DEBUG(SSSDBG_MINOR_FAILURE, "Could not parse name %s\n",
+ parent_internal_name);
+ goto done;
+ }
+
+ ret = sss_mc_refresh_group(parent_shortname);
+ talloc_free(parent_internal_name);
+ talloc_free(parent_shortname);
otherwise LGTM
LS
"""
See the full comment at
https://github.com/SSSD/sssd/pull/18#issuecomment-245334928