URL:
https://github.com/SSSD/sssd/pull/977
Title: #977: sss_ptr_hash: internal refactoring
pbrezina commented:
"""
Thank you. It looks good to me. I have just some suggestions about deleting items that
might simplify the code more...
The basic idea is to move `hash_delete` into `sss_ptr_hash_value_destructor`. Would it be
possible?
Then you could do the following changes:
- `sss_ptr_hash_delete` use lookup -> free(value) / calls hash_delete from cb ->
free(payload)
- `sss_ptr_hash_delete_all` - use `hash_values` instead of `hash_keys` and iterate over
values and just call `talloc_free(values)`
- `sss_ptr_hash_delete_cb` - `talloc_steal(NULL, value)` could be moved to
`sss_ptr_hash_value_destructor`
"""
See the full comment at
https://github.com/SSSD/sssd/pull/977#issuecomment-580706435