On 03/07/2016 03:57 PM, Petr Cech wrote:
On 03/07/2016 01:53 PM, Pavel Březina wrote:
> On 03/07/2016 01:11 PM, Pavel Březina wrote:
>> On 03/02/2016 05:04 PM, Petr Cech wrote:
>>>
>>> ret = sysdb_search_entry(mem_ctx, domain->sysdb, dn,
>>> LDB_SCOPE_SUBTREE, filter, attrs,
>>> msgs_count, msgs);
>>> if (ret) {
>>> goto fail;
>>> }
>>>
>>> talloc_zfree(tmp_ctx);
>>> return EOK;
>>>
>>> fail:
>>> if (ret == ENOENT) {
>>> DEBUG(SSSDBG_TRACE_INTERNAL, "No such entry\n");
>>> }
>>> else if (ret) {
>>> DEBUG(SSSDBG_MINOR_FAILURE, "Error: %d (%s)\n", ret,
>>> strerror(ret));
>>> }
>>> talloc_zfree(tmp_ctx);
>>
>> There is already good debug message per dn and filter case. Move this to
>> sysdb_search_entry and use done scheme instead of fail, please.
>>
Whole fail block is redundant, you've right. Addressed.
I would like to remove redundant error messages for other calls of
sysdb_search_entry. Unfortunately, I found that I had to miss and look
to other function. Therefore, I have to still fix the patch.
I am sorry.
--
Petr^4 Čech