On 08/26/2013 03:53 PM, Jakub Hrozek wrote:
On Mon, Aug 26, 2013 at 02:58:18PM +0200, Ondrej Kos wrote:
> Attached patch adds sysdb routine to search users/groups by their
> SID, which will be needed for ticket 1568.
> I'm sending it now, because one of the patches I have in this
> working branch (store group SID) was already written and posted on
> the list by Sumit, so not to waste time again :)
There is quite some code duplication between the two functions. Can we
have a single one that would also take a search base and either
objectlass or filter as arguments? The objectclass or filter would then
be and-end with SYSDB_SID_STR=%s. User and group functions could then be
just thin wrappers.
Also I would prefer a unit test for any new sysdb API.
sssd-devel mailing list
New patch attached.
Associate Software Engineer
Identity Management - SSSD
Red Hat Czech