On (05/02/14 15:31), Alexander Bokovoy wrote:
Hi,
thanks to Alexey Shabalin (ALT Linux Team), following patch makes sure
SSSD will compile against MIT Kerberos with headers installed in a
subdirectory of /usr/include (/usr/include/krb5 in ALT Linux).
Please apply.
--
/ Alexander Bokovoy
Few comments
0. Please follow
https://fedorahosted.org/sssd/wiki/DevelTutorials#Submittingapatchupstream
We do not rename patches, after "git format-patch"
1. It would be nice to have a ticket in the SSSD trac.
another comment inline
From 09893453dadca3488185142b6fef0df455fdbe69 Mon Sep 17 00:00:00
2001
From: Alexander Bokovoy <abokovoy(a)redhat.com>
Date: Wed, 5 Feb 2014 15:27:37 +0200
Subject: [PATCH] Make sure KRB5_CFLAGS is used properly
There are cases when MIT Kerberos is installed with includes
in a subdirectory of /usr/include (or /usr/local/include).
In such case we have to properly use KRB5_CFLAGS to reach them.
Thanks to Alexey Shabalin (a.shabalin(a)gmail.com)
---
Makefile.am | 7 ++++++-
src/external/krb5.m4 | 5 +++++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 9c155d6..3d8f689 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -981,6 +981,7 @@ strtonum_tests_SOURCES = \
src/util/strtonum.c
strtonum_tests_CFLAGS = \
$(AM_CFLAGS) \
+ $(KRB5_CFLAGS) \
$(CHECK_CFLAGS)
strtonum_tests_LDADD = \
$(SSSD_LIBS) \
It is a joke?
Do you really that mean strtonum_tests need kerberos header file?
Thank you your patch
LS