On 01/22/2016 02:55 PM, Pavel Reichl wrote:
Hello,
please see simple test adding test for
https://fedorahosted.org/sssd/ticket/2922.
Sumit proposed to test if mapping of UNIX MAX_ID + 1 fails to be mapped
to SID.
Without patch for #2922 test fails otherwise test passes.
Thanks.
Hi,
Please define TEST_2922_MAX_ID_PLUS_ONE macro like this:
#define TEST_2922_MAX_ID_PLUS_ONE (TEST_2922_MAX_ID + 1)
I asked Jakub about the asserts in setup functions and he
confirmed that we should not use them in test setup functions.
So please do not use asserts in the tests but return
an error code. It is OK if you only change the functions
that you added, no need to remove the asserts from other
setup functions that already exist in the file.
I think it is OK to use DEBUG macro with SSSDBG_FATAL_FAILURE
level in the setup fuctions as well.
Michal