URL:
https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
sumit-bose commented:
"""
Retry logic means that something failed but we have resolved the
server successfully so imho the retry logic should be implemented elsewhere. Also at this
time the retry logic spans across two components - `be_resolve_server` and
`sdap_cli_connect` instead of being implemented at only one place - this is because
`be_resolved_server` is not the component that failed. This will have to happen in other
components as well if we want to reuse it so the only part that gets reused is only the
attempt counter.
Hi,
that's a fair point. @ikerexxe, would you mind the change the code and follow
@pbrezina's suggestion?
bye,
Sumit
My suggestion is to implement it only in `sdap_cli_connect_done` and retry only
`sdap_connect_send`, but if Summit thinks that this is beneficial I won't oppose.
However, triple check that storing `fo_server` pointer will not cause issues and that you
don't need `for_ref_server`.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5532#issuecomment-816696617