-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/23/2010 07:50 AM, Jakub Hrozek wrote:
These patches must be applied on top of the "Do not check entries..." one.
[PATCH 1/2] Store lastLogin attribute when authenticating online This is needed for the second patch as we rely on lastLogin to decide whether to delete an entry or not.
[PATCH 2/2] Better cleanup task handling Implements a different mechanism for cleanup task. Instead of just deleting expired entries, this patch adds a new option login_cache_timeout for domains. If an entry is expired and the last login was more days in the past that login_cache_timeout, the entry is deleted.
Groups are deleted if they are expired and and no user references them (no user has memberof: attribute pointing at that group).
The parameter login_cache_timeout is not LDAP-specific, so that other future backends might use the same timeout setting.
Patch 0001: Ack.
Patch 0002: Nack.
+ 'login_cache_timeout' : _('How long to keep cached entries with after last successfull login'), Should read _('How long to keep cached entries after last successful login (days)')
Similarly, you misspelled "successful" in the manpage.
Also, you bumped the value of IPA_OPTS_BASIC_TEST without actually adding the option to ipa_common.c. That defeats the purpose of this test. It's meant to remind you that ipa_common.c needs to be updated when ldap_common.c is.
The approach here looks good, but I've also asked Simo to take a look as well, since he originally proposed the design.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/