>From 1217739310235ad640c7e9fecfbbb50e43a5220b Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Mon, 25 May 2015 10:20:39 +0200 Subject: [PATCH 17/24] DP: Set extra_value to NULL for enum requests Some providers, notably IPA, rely on extra_value to be either a useful value or NULL. In enumeration, however, extra_value was random. Set the extra_value pointer explicitly to NULL to make it clear that it's not used for enumeration and also use talloc_zero as future-proof. Resolves: https://fedorahosted.org/sssd/ticket/2659 Reviewed-by: Sumit Bose (cherry picked from commit d9296ba018228ac6a19f710b8bb9044c4ea9ab5b) (cherry picked from commit 2dfb4ed5a36a7be6bcde60e042811b81e83c4850) --- src/providers/data_provider_be.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/providers/data_provider_be.c b/src/providers/data_provider_be.c index 3dd635f28ef85b3dcbc09bd51cea86963982a6c8..b9bdc0a8270af428277ed09e134d7d615f403a27 100644 --- a/src/providers/data_provider_be.c +++ b/src/providers/data_provider_be.c @@ -1138,7 +1138,7 @@ static int be_get_account_info(struct sbus_request *dbus_req, void *user_data) goto done; } - req = talloc(be_req, struct be_acct_req); + req = talloc_zero(be_req, struct be_acct_req); if (!req) { err_maj = DP_ERR_FATAL; err_min = ENOMEM; @@ -1185,6 +1185,7 @@ static int be_get_account_info(struct sbus_request *dbus_req, void *user_data) } else if (strcmp(filter, ENUM_INDICATOR) == 0) { req->filter_type = BE_FILTER_ENUM; req->filter_value = NULL; + req->extra_value = NULL; } else { err_maj = DP_ERR_FATAL; err_min = EINVAL; -- 2.4.3