>From 3b9f8f2e49878330939cd474071d6ed313efcf27 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Fri, 22 May 2015 15:19:31 +0200 Subject: [PATCH 16/24] Download complete groups if ignore_group_members is set with tokengroups Resolves: https://fedorahosted.org/sssd/ticket/2644 When tokenGroups are enabled, we save groups using their SID as the RDN attribute during initgroups() and later, if the groups is requested and saved again with the full name, remove the original and save the new group entry. Saving the new group entry would break if ignore_group_members is also set, because the new group entry would lack the "member" attribute, so the member/memberof links between the new group and the user entry wouldn't be established again. This patch changes the initgroups processing so that the full group object is fetched when initgroups is enabled but together with ignore_group_members. This solution imposes some performance impact, because instead of one search for tokenGroups we also need to resolve the groups. The more systematic solution would be to get rid of removing the group entry as described in https://fedorahosted.org/sssd/ticket/2656 To reproduce the bug, set: ignore_group_members = True with a backend that uses: id_provider = ad Then run: $ id aduser@ad_domain.com $ id aduser@ad_domain.com Reviewed-by: Sumit Bose (cherry picked from commit ee44aac95e42c3cb634876286a2aa4960ac69a2b) (cherry picked from commit 44f35a0f32785bf460b5d05424f5e9a15f4f4028) --- src/providers/ldap/sdap_async_initgroups_ad.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/providers/ldap/sdap_async_initgroups_ad.c b/src/providers/ldap/sdap_async_initgroups_ad.c index 15855b4e32c1d71e22699bd5baf46926a8b95ea4..1de851807df3a65683b3a2e622e467855ae8c126 100644 --- a/src/providers/ldap/sdap_async_initgroups_ad.c +++ b/src/providers/ldap/sdap_async_initgroups_ad.c @@ -1451,7 +1451,18 @@ sdap_ad_tokengroups_initgroups_send(TALLOC_CTX *mem_ctx, state->use_id_mapping = use_id_mapping; state->domain = domain; - if (state->use_id_mapping && !IS_SUBDOMAIN(state->domain)) { + /* We can compute the the gidNumber attribute from SIDs obtained from + * the tokenGroups lookup in case ID mapping is used for a user from the + * parent domain. For trusted domains, we need to know the group type + * to be able to filter out domain-local groups. Additionally, as a + * temporary workaround until https://fedorahosted.org/sssd/ticket/2656 + * is fixed, we also fetch the group object if group members are ignored + * to avoid having to transfer and retain members when the fake + * tokengroups object without name is replaced by the full group object + */ + if (state->use_id_mapping + && !IS_SUBDOMAIN(state->domain) + && state->domain->ignore_group_members == false) { subreq = sdap_ad_tokengroups_initgr_mapping_send(state, ev, opts, sysdb, domain, sh, name, orig_dn, @@ -1491,7 +1502,9 @@ static void sdap_ad_tokengroups_initgroups_done(struct tevent_req *subreq) req = tevent_req_callback_data(subreq, struct tevent_req); state = tevent_req_data(req, struct sdap_ad_tokengroups_initgroups_state); - if (state->use_id_mapping && !IS_SUBDOMAIN(state->domain)) { + if (state->use_id_mapping + && !IS_SUBDOMAIN(state->domain) + && state->domain->ignore_group_members == false) { ret = sdap_ad_tokengroups_initgr_mapping_recv(subreq); } else { ret = sdap_ad_tokengroups_initgr_posix_recv(subreq); -- 2.4.3