On Wed, May 11, 2016 at 10:34:47AM +0200, Pavel Březina wrote:
On 05/10/2016 01:31 PM, Pavel Březina wrote:
> On 05/02/2016 03:02 PM, Petr Cech wrote:
> > On 04/28/2016 01:39 PM, Pavel Březina wrote:
> > > Hi, just few nitpicks:
> > >
> > > Patch 1 NEGCACHE: Adding timeout to struct sss_nc_ctx
> > >
> > > > +int responder_get_neg_timeout_from_confdb(struct confdb_ctx *cdb,
> > > > + uint32_t *neg_timeout)
> > > > +{
> > > > + int value;
> > > > + int ret = EOK;
> > >
> > > Please, use errno_t instead of int as a type of return code. And also do
> > > not initialize it with declaration (especially not to EOK), it tends to
> > > hide issues where you forget to set ret (I know it is not this case, but
> > > it is a bad habit).
> > >
> > > > neg_timeout
> > >
> > > I think ncache_timeout would be a better name to use throughout the code
> > > since we shortcut "negative cache" to ncache all over the code
and you
> > > remove most of neg_timeout names in following patches.
> >
> > Hi Pavel,
> >
> > I addressed all nitpicks. Patches are attached.
> >
> > Regards
>
> Ack. CI has been running for hours... if it ever finishes I'll send the
> result.
CI
http://sssd-ci.duckdns.org/logs/job/43/05/summary.html
All patches pushed to master:
* 4f87f99f95891ebc0814e4566fa2defb4359b008
* 7910bc6c991b63fa716d77eba08b5f5d83ea6a72
* e50bd9752c7c94bc06d384487fef890ef8cc0e17
* 45afb8190a9db5ef5fb9b3ca7e4967d2228c8f1d
* beb07d2f45856d4f3135f173cce551a2aa878f57
* f77ba726e3f8bd1e3cabdee66f38c4ed7a771913
* 0393f0d44ac92035de29a8bc8b2005db6d90b640
* 39d36216a1692eee6cc5359f6c7ccaa7789be76d