On 08/18/2016 12:22 PM, Petr Cech wrote:
On 08/18/2016 12:19 PM, Lukas Slebodnik wrote:
> ehlo,
>
> python wrapper for retrieving netgroups was push to early.
> Attached patch fixes it.
>
> LS
Thanks, Lukas. I will take a look
and I will try it with my tests :-)
Hi Lukas,
your patch works how we expected.
There are a few PEP8 issue:
$ pep8 src/tests/intg/sssd_netgroup.py
src/tests/intg/sssd_netgroup.py:131:80: E501 line too long
src/tests/intg/sssd_netgroup.py:150:80: E501 line too long
src/tests/intg/sssd_netgroup.py:151:80: E501 line too long
Please, fix them.
I could say LGTM, but... you know, I have issue with my nested netgroups
tests. I rather wait until I will resolve this one. And I will see that
this your patch is final.
Thanks for your work, Lukas.
Regards
--
Petr^4 Čech