URL:
https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
lslebodn commented:
"""
We should skip secrets test on rhel6.
So the patch "ci: do not build secrets on rhel6" should also contain
```
diff --git a/src/tests/intg/test_secrets.py b/src/tests/intg/test_secrets.py
index d71c19045..6dc4c81ed 100644
--- a/src/tests/intg/test_secrets.py
+++ b/src/tests/intg/test_secrets.py
@@ -32,6 +32,14 @@ from util import unindent
from secrets import SecretsLocalClient
+RESP_PATH = os.path.join(config.LIBEXEC_PATH, "sssd",
"sssd_secrets")
+if not os.access(RESP_PATH, os.X_OK):
+ if pytest.__version__ < "3.0.0":
+ pytest.skip()
+ else:
+ pytestmark = pytest.mark.skip
+
+
def create_conf_fixture(request, contents):
"""Generate sssd.conf and add teardown for removing
it"""
conf = open(config.CONF_PATH, "w")
```
@jhrozek Did you mean something like this in comment "It would be cleaner to use
pytest.mark.skipif on the package level" in `test_kcm.py` :-) BTW I am not sure
whether it's the best pythonic way but it works :-)
"""
See the full comment at
https://github.com/SSSD/sssd/pull/198#issuecomment-290040874