On Sun, Jan 26, 2014 at 9:36 PM, Simo Sorce <simo@redhat.com> wrote:
On Thu, 2014-01-16 at 11:02 +0200, Noam Meltzer wrote:
> Following the design document:
> https://fedorahosted.org/sssd/wiki/DesignDocs/rpc.idmapd%20plugin
>
> You can find in the following 5 patches my implementation.

Hi Noam,
it is a good start, as you can see I've sent comments on the various
patches. I think we are close, but there are quite some fixes to make.

Hi all

Thanks for all the input. I will refer to every comment (most of them are manner of style/standard so there's no debate there anyhow)


I do not have any additional comment on the whole patchset at the moment
and I agree with Lukas' comment on patch 3.

Btw I see that you had to include an internal file from libfsidmapd, but
I've seen no request on the linux-nfs mailing list to ask to make it
public.
I think we should have a conversation with them because this code could
be also contributed directly to linux-nfs instead of sssd as it is now.
That was my initial intention too, but after reading looking into the sssd source code and the various clients it provides, it felt more appropriate to make this plugin part of the sssd project.
However, for that we'll need to have public API to access sssd. At the moment, I only see "sss_nss_idmap.h", "sss_idmap.h" & "ipa_hbac.h" publicly exported. Am I missing something here?


Either way we should discuss with the nfs-utils maintainers whether they
want to host the code by themselves or whether they can make libnfsidmap
plugin interface public. I do not like very much to go forward
indefinitely including a private non-versioned interface from another
library in our code, as it would break badly should linux-nfs make
changes, which they can, because, so far, the interface is marked
'internal' so they are not giving any guarantee of ABI compatibility
going forward.

Do you want to start this discussion yourself on the list ?
I will start that discussion.
 

Thanks,
Simo.


--
Simo Sorce * Red Hat, Inc * New York




--
Noam Meltzer
Linux Software Engineer
PRIMARY DATA

P.O. Box 12650, Herzliya Pituach 4673300
9 Hamenofim St. Akerstein Towers, Tower A, 5th fl. Herzliya

Office: +972-77-8981888 | Fax: +972-3-7617140 | Mobile: +972-54-5873843

Email: noam@primarydata.com