>From 1a5be3c0c6112350c24cfcf186de826b6a170dbd Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Wed, 12 Mar 2014 17:38:22 +0100 Subject: [PATCH] AD: Continue if sssd failes to check extra members Reported by scan-build for (mi = 0; group_only[mi]; mi++) { ^~~~~~~~~~ warning: Array access (from variable 'group_only') results in a null pointer dereference It can happend if function ad_group_extra_members fails (ret != EOK) --- src/providers/ad/ad_id.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/providers/ad/ad_id.c b/src/providers/ad/ad_id.c index e68c8a8ff9e6960a0bf4f67dea34ed70cc31bcbf..3425b35555b78ec5cdae2d748a660b9ba5619e94 100644 --- a/src/providers/ad/ad_id.c +++ b/src/providers/ad/ad_id.c @@ -753,6 +753,7 @@ ad_enum_cross_dom_members(struct sdap_options *opts, ret = ad_group_extra_members(tmp_ctx, msgs[i], dom, &group_only); if (ret != EOK) { DEBUG(SSSDBG_OP_FAILURE, "Failed to check extra members\n"); + continue; } else if (group_only == NULL) { DEBUG(SSSDBG_TRACE_INTERNAL, "No extra members\n"); continue; -- 1.8.5.3