On Thu, Oct 04, 2012 at 11:49:54AM +0200, Ondrej Kos wrote:
On 10/04/2012 11:11 AM, Jakub Hrozek wrote:
>On Thu, Oct 04, 2012 at 08:13:36AM +0200, Ondrej Kos wrote:
>>>I'd like to see two more changes:
>>> 1) Don't pass the whole krb5child_req structure to
>>> cc_be_check_existing(), it's enough to just pass the option value
or
>>> if we needed more options the whole options structure.
>>>
>>As we discussed it with Michal, we decided to pass whole structure,
>>since we're using three of its members now, but no problem, changed.
>
>Yeah, it's mostly about keeping the interface unobfuscated so that the
>caller can see what's being passed in and the interface can also be
>reused in code that doesn't know the child_req structure.
>
>>> 2) Rename the function from cc_file_check_template to something that
>>> doesn't include _file_ and make it static.
>>done
>>
>>fixed patch attached
>>
>>O.
new patch attached
O.
Thank you, Ack