On (11/07/16 07:44), Michal Zidek wrote:
> Ok, I split the patches (one per option).
>
> Michal
>From 4c11e6cfcfee3cad801d513d75e136e4bd3bd598 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Michal=20=C5=BDidek?= <mzidek(a)redhat.com>
> Date: Mon, 11 Jul 2016 13:03:28 +0200
> Subject: [PATCH 1/4] config: Allow timeout for all sevices
>
> Fixes:
>
https://fedorahosted.org/sssd/ticket/3068
>
> Allow option "timeout" for all sevices.
> ---
> src/config/cfg_rules.ini | 7 +++++++
> src/config/etc/sssd.api.conf | 2 +-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
Almost ACK
I realized that there is an unused macro CONFDB_SERVICE_TIMEOUT
Could you remove it in this patch?
This macro is not used since commit 31d97bce8f113276bf73c7d4349f720cd5edbcb8
(3+ years)
>From 851e274f5a8067f10b2fd29acc6a3bfc8da49cd3 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Michal=20=C5=BDidek?= <mzidek(a)redhat.com>
> Date: Mon, 11 Jul 2016 13:11:41 +0200
> Subject: [PATCH 2/4] config: override_space is monitor's option
>
> Fixes:
>
https://fedorahosted.org/sssd/ticket/3068
>
> We read override_space from [sssd] not
> [nss] section.
> ---
ACK
>From c478a9440bb50c56c6004da806c0cdf8e9bbcc56 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Michal=20=C5=BDidek?= <mzidek(a)redhat.com>
> Date: Mon, 11 Jul 2016 13:23:40 +0200
> Subject: [PATCH 3/4] config: Fix user_attributes
>
> Fixes:
>
https://fedorahosted.org/sssd/ticket/3068
>
> Option user_attributes is also available in
> NSS responder, but not in PAC responder.
> ---
ACK
>From ee4449c7b5c6154bfb079725e62874948c42124d Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Michal=20=C5=BDidek?= <mzidek(a)redhat.com>
> Date: Mon, 11 Jul 2016 13:34:03 +0200
> Subject: [PATCH 4/4] config: Add config_file_version to schema
>
> Fixes:
>
https://fedorahosted.org/sssd/ticket/3068
> ---
> src/config/cfg_rules.ini | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/config/cfg_rules.ini b/src/config/cfg_rules.ini
> index 5c8d05a..635c078 100644
> --- a/src/config/cfg_rules.ini
> +++ b/src/config/cfg_rules.ini
> @@ -39,6 +39,7 @@ option = user
> option = default_domain_suffix
> option = certificate_verification
> option = override_space
> +option = config_file_version
>
> [rule/allowed_nss_options]
> validator = ini_allowed_options
> --
> 1.8.3.1
>
Python API schema is not generated yet
therefore we should add this option also
to src/config/etc/sssd.api.conf.
It was probably removed with the change from default 1 -> 2
BTW. We need to also allow section + add default options for
"secrets" service. So you will need to modify the 1st patch.
I will push acked patches after CI.
LS
Sending the patches that were not acked + patch
that adds the 'secrets' service.
Michal