On Tue, 2012-10-30 at 15:24 +0100, Jakub Hrozek wrote:
On Fri, Oct 19, 2012 at 12:27:44PM +0200, Pavel Březina wrote:
> 0001: do not leak memory on failure in *_process_init()
>
> 0002:
https://fedorahosted.org/sssd/ticket/1575
>
> 0003: free request table as the first thing when deallocating rctx
> Because we have changed the hierarchy we do not need to special case
> responder shut down in dp request destructor anymore. More
> information may be found in the list archive:
>
https://lists.fedorahosted.org/pipermail/sssd-devel/2012-October/011663.html
>
> 0004: just a little coding style fix
> [PATCH 1/4] do not leak memory on failure in *_process_init()
If sss_process_init failed, in the per-responder _process_init functions,
you would free a random pointer.
> [PATCH 2/4] change responder contexts hierarchy
Looks good to me and sanity testing passed as well. I have applied the
patches and will them on my laptop until the other comments are fixes to
test them in a real environment.
> [PATCH 3/4] free request table as the first thing when deallocating rctx
Isn't the order guaranteed by the talloc itself?
The children are freed in arbitrary order, however all children of a
specific context are freed before the parent.
Simo.
--
Simo Sorce * Red Hat, Inc * New York