URL:
https://github.com/SSSD/sssd/pull/1009
Title: #1009: Use ndr_pull_steal_switch_value for modern samba versions
noelpower commented:
"""
Thank you. The code is copied from samba sources so perhaps it would
make sense to update the whole sources instead of just this function? From a quick look it
seems that there were more changes over the time.
I can't speak for the rest of the sources, I am not familiar with the sssd code. In
this one example replacing ndr_pull_get_switch_value with ndr_token_peek post samba 4.12
just isn't wise given the bug that is being addressed.
I'm guessing from the comment above that this code was copied from the samba source
tree at some time. In samba however this type of code is generated from idl and so is
somewhat dynamic, however the generated code is always in step with the version of samba
it is used with (since it is in-tree).
While it is possible to re-copy (or refresh) the sssd source from later versions of
generated code from the samba source tree your mileage may vary when trying to build with
different versions of samba.
The correct solution would be for sssd to generate the necessary code itself as part of
the build, presumably there are technical or practical reasons why this hasn't been
done .
"""
See the full comment at
https://github.com/SSSD/sssd/pull/1009#issuecomment-603355855